This chapter describes the relevant coding practices in Wine, that you should be aware of before doing any serious development in Wine.
Patches are submitted via email to the Wine patches mailing
list, <wine-patches@winehq.org>
. Your patch
should include:
A meaningful subject (very short description of patch)
A long (paragraph) description of what was wrong and what is now better. (recommended)
A change log entry (short description of what was changed).
The patch in diff -u format
cvs diff -u works great for the common case where a file is edited. However, if you add or remove a file cvs diff will not report that correctly so make sure you explicitly take care of this rare case.
For additions simply include them by appending the diff -u /dev/null /my/new/file output of them to any cvs diff -u output you may have. Alternatively, use diff -Nu olddir/ newdir/ in case of multiple new files to add.
For removals, clearly list the files in the description of the patch.
Since wine is constantly changing due to development it is strongly recommended that you use cvs for patches, if you cannot use cvs for some reason, you can submit patches against the latest tarball. To do this make a copy of the files that you will be modifying and diff -u against the old file. I.E.
diff -u file.old file.c > file.txt